search

rive-app / rive-ios

iOS runtime for Rive
MIT License
462 stars 53 forks source link

Rive file with nested arboard is freezing after loading #302

Closed jonyw4 closed 2 months ago

jonyw4 commented 2 months ago

Description

Rive file with nested arboard is freezing after loading only in Rive iOS package. In React library and Rive editor is working properly.

Provide a Repro

https://github.com/Ursula-AI/rive-ios-nested-artboard-bug

Source .riv/.rev file

Expected behavior

Nested artboards working just like a normal artboard without freezing.

Screenshots

Video recordings on Rive and iOS Preview: https://github.com/Ursula-AI/rive-ios-nested-artboard-bug/tree/51bca87c0d995f33e19e59d989508cf9d42dd759/Rive%20iOS%20Nested%20Arboard%20Bug/Files

Device & Versions

jonyw4 commented 2 months ago

It may be related to this?

https://github.com/rive-app/rive-ios/pull/112 https://github.com/rive-app/rive-ios/pull/113

mjtalbot commented 2 months ago

thanks for the report & the repro!

We've push an update for this. And i've updated your sample project to use 5.11.2, and the bug no longer reproduces.

Please give it a try and let us know if this resolves the issue for you

jonyw4 commented 2 months ago

Wow that was fast @mjtalbot! Thank you very much 🙇🏻‍♂️ Now I noticed some other bug: exposed inputs from nested artboards are not working.

I've updated the repository with a new Rive file that has a state machine with both nested input and normal input.

image

Do I need to open a new issue?

mjtalbot commented 2 months ago

Hi @jonyw4, thanks for reporting the additional issue, i've thrown it into a separate issue.

Updating the sample code with a repro it really cuts down the time and makes it clear what is not working, so that is really appreciated!

i'll close this issue and will get back in the other once we have updates on it!