search

rive-app / rive-ios

iOS runtime for Rive
MIT License
516 stars 58 forks source link

Mark RiveModel and RiveViewModel as @objc #321

Closed Besik13 closed 5 months ago

Besik13 commented 6 months ago

These changes allow to generate Kotlin declarations to use in Multiplatform code

Besik13 commented 5 months ago

@mjtalbot could you please review this PR?

mjtalbot commented 5 months ago

Hi @Besik13, thank you for bringing this change to my attention. I'll get this applied to our mono repo, give it a test & get it applied downstream.

In the meantime, using the @objcatttributes is not something we currently utilise in our samples or tests. If i'm looking at this right we should be able to add some tests to make sure that these methods are exposed to objective c. i'm not sureif there is anything else that is sensible to do here to prevent or detect future regressions here

mjtalbot commented 5 months ago

hi @Besik13 , we've included this change in our latest release, barring a convenience init that clashes with some of our examples that are set up.

Would love to hear if this is having the desired impact for you, but i'm going to close this pr in the meantime

beskhmelnytsyn-genesis commented 5 months ago

Thanks so much! That's what we need!