rive-app / rive-react-native

MIT License
554 stars 44 forks source link

Not working with Xcode 15, iOS17 #209

Open jbhavin opened 1 year ago

jbhavin commented 1 year ago

hello team,

we upgraded our react native version from 0.76.0 to 0.72.7 with latest Xcode15 and it is stop working. please find screenshot for attachment.

Screenshot 2023-11-17 at 8 37 53 PM Screenshot 2023-11-17 at 8 37 35 PM

react-native : 0.72.7 react : 18.2.0 rive-react-native : '^6.1.1' xcode : 15 mac os: Sonama 14.1.1

zplata commented 1 year ago

Hi @jbhavin - we should have an update to this package soon here that might assist with the XCode 15 support. We'll comment back here when that release lands and you can try it out.

immanjeba98 commented 9 months ago

is it update? i'm having same issue how can i resolve it?

brascene commented 4 months ago

Same issue here, and when I hardcode the minimum iOS deployment target in Podfile to 14, pod install goes well, but app crashes on start even i didn't use the lib anywhere in the code, just installed it, and error is something in react-core, with console message: Unbalanced calls start/end for tag 19

Screenshot 2024-07-17 at 12 26 16

I tried this with:

Xcode: 15.4 (15F31d) iPhone 15 Pro (17.0.1) React Native: 0.74.2 Rive-React-Native: ^7.3.0

JslinSir commented 3 months ago

Add the following

require Pod::Executable.execute_command('node', ['-p',
  'require.resolve(
    "react-native/scripts/react_native_pods.rb",
    {paths: [process.argv[1]]},
  )', __dir__]).strip

  MIN_IOS_OVERRIDE = '14.0'
  if Gem::Version.new(MIN_IOS_OVERRIDE) > Gem::Version.new(min_ios_version_supported)
      min_ios_version_supported = MIN_IOS_OVERRIDE
  end  

platform :ios, min_ios_version_supported
prepare_react_native_project!
brascene commented 3 months ago

Add the following

require Pod::Executable.execute_command('node', ['-p',
  'require.resolve(
    "react-native/scripts/react_native_pods.rb",
    {paths: [process.argv[1]]},
  )', __dir__]).strip

  MIN_IOS_OVERRIDE = '14.0'
  if Gem::Version.new(MIN_IOS_OVERRIDE) > Gem::Version.new(min_ios_version_supported)
      min_ios_version_supported = MIN_IOS_OVERRIDE
  end  

platform :ios, min_ios_version_supported
prepare_react_native_project!

That's not resolving the issue in RCTShadowView

terrysahaidak commented 1 month ago

hey @brascene have you found a solution for this crash?

i just spent two days figuring out what breaks our app after upgrading to 0.74 and only after removing rive it worked...

brascene commented 1 month ago

hey @brascene have you found a solution for this crash?

i just spent two days figuring out what breaks our app after upgrading to 0.74 and only after removing rive it worked...

yes @terrysahaidak i found a solution,i downgraded react native version to 0.73.7 😅 although it doesn't seem a big change (0.73 and 0.74) but there actually were some major changes regarding yarn, yoga and other breaking changes.

terrysahaidak commented 1 month ago

@brascene it looks like downgrading rive to 7.2.0 also fixes the problem, so i'm gonna stick to it in the meantime... thanks for the response