Fix Alignment leak! - Githubissues

rive-app / rive-wasm

Wasm/JS runtime for Rive

MIT License

669 stars 46 forks source link

Fix Alignment leak! #270

Closed luigi-rosso closed 1 year ago

luigi-rosso commented 1 year ago

Alignment now exposed as an enum so that emscripten doesn’t new it every time we get it.
Use the same clang-format as the rest of our C++ code (gotta mino-repo this soon)
Use address sanitizer for helping debug memory leaks in debug mode.
Better compiler/linker flag separation between debug and release mode in our premake scripts.

luigi-rosso commented 1 year ago

Also bumps to latest rive-cpp master.

luigi-rosso commented 1 year ago

Only reason I added the clang-format was that my vscode was trying to reformat it with default clang-format settings or not format it at all. Not sure what we were doing prior to this? Were we just not formatting any of the C++ code here?

csmartdalton commented 1 year ago

Only reason I added the clang-format was that my vscode was trying to reformat it with default clang-format settings or not format it at all. Not sure what we were doing prior to this? Were we just not formatting any of the C++ code here?

Ah ok, no worries. Your comments helped!

csmartdalton commented 1 year ago

Ship it!

(After the build passes :)