rive-app / rive-wasm

Wasm/JS runtime for Rive
MIT License
660 stars 46 forks source link

yours examples doesnt work !!!!!! #338

Closed desdamo closed 3 months ago

desdamo commented 8 months ago

<-- Thanks for using Rive!

If something isn't working like you expected, please:

If you think you found a bug or if you can't find what you're looking for in our docs, fill out the template below.

-->

Description

<-- A clear and concise description of what the problem is. -->

Provide a Repro

<-- Please provide the most minimal repro you can:

-->

Source .riv/.rev file

<-- Attaching runtime-exported .riv file that reproduces the issue is immensely helpful for our team to identify the problem as fast as possible and fix it. Please also include the source (.rev) by downloading a backup from the Editor.

N.B. Because GitHub only supports certain file types use a ZIP archive to upload .riv/.rev files to this issue.

You can also privately share the .riv/.rev file with us at hello@rive.app. -->

Expected behavior

<-- A clear and concise description of what you expected to happen. -->

Screenshots

<-- If applicable, add screenshots to help explain your problem. -->

Screenshot

Browser & Versions (please complete the following information)

Additional context

<-- Add any other context about the problem here. -->

zplata commented 7 months ago

Hi! I can't tell from the description what seems to not be working re: the examples, but hopefully we can clarify a few things. The example apps are by default set up to work with a local build of the JS/WASM runtimes. Some examples are stale (which we definitely need to clean up), but if you're able to build successfully and still not get the example apps to work, please let us know! You can find more here on building locally and running the example apps: https://github.com/rive-app/rive-wasm/blob/master/CONTRIBUTING.md#local-development

You can also replace the local build path in the package.json for the example apps to point to a latest deployed version if you prefer. So for example, in this example app: https://github.com/rive-app/rive-wasm/blob/master/js/examples/_frameworks/neostream-events/package.json#L12

You could change:

"@rive-app/canvas": "file:../../../npm/canvas_single"

to something like:

"@rive-app/canvas": "^2.7.6"
zplata commented 3 months ago

Closing as we haven't heard back, but feel free to open a new issue if you have a specific example that does not work. We also cleaned up/deleted some stale examples that used old versions of the runtime to make it clear what examples you can reference that are active. Thanks!