rivella50 / atahualpa

GNU General Public License v3.0
3 stars 0 forks source link

Wordpress 6.6 makes opening of subpages in Menu1 impossible #4

Open extremecarver opened 3 months ago

extremecarver commented 3 months ago

Updating to Wordpress 6.6 causes the submenu entries to not open anymore - so yu can only access top level pages from menu1 (and likely other menus). See solution/workaround: https://github.com/rivella50/atahualpa/issues/4#issuecomment-2252321306

rivella50 commented 3 months ago

@extremecarver Do you get a corresponding error displayed which can lead us to a solution for that issue?

extremecarver commented 3 months ago

No nothing in console. Error not happening to your site(s)?

rivella50 commented 3 months ago

I haven't updated yet to that WP version for the site i use Atahualpa. Do you have time to investigate it? I could have a look at it next week earliest.

extremecarver commented 3 months ago

Ah okay, I have no clue how to investigate it as I see no errors. But I can just not update wordpress for a couple of weeks

rivella50 commented 3 months ago

Perhaps the release notes for version 6.6 could give a hint...

extremecarver commented 3 months ago

Performance updates WordPress 6.6 includes important updates like removing redundant WP_Theme_JSON calls, disabling autoload for large options, eliminating unnecessary polyfill dependencies, lazy loading post embeds, introducing the data-wp-on-async directive, and a 33% reduction in template loading time in the editor.

That's not telling much

rivella50 commented 3 months ago

But we could have a look in the list of changed files (mainly menu related) what has changed there.

extremecarver commented 3 months ago

Above my knowledge of php. Seems only elemontor has a similar problem: https://wordpress.org/support/topic/wordpress-6-6-header-dropdown-menu-fail/

rivella50 commented 3 months ago

I've just updated to Wordpress 6.6 on a local Docker installation for the homepage i support, and don't encounter the problem you mentioned, i.e. submenu items do show up and are clickable:

Screenshot 2024-07-23 at 15 22 47

extremecarver commented 3 months ago

That's very strange, I tried with all plugins deactivated. Which php version are you using?

On Tue, 23 Jul 2024, 15:28 Valentin Treu, @.***> wrote:

I've just updated to Wordpress 6.6 on a local Docker installation for the homepage i support, and don't encounter the problem you mentioned, i.e. submenu items do show up and are clickable:

Screenshot.2024-07-23.at.15.22.47.png (view on web) https://github.com/user-attachments/assets/ba13d5c3-6978-4575-8b35-0da447a7caf4

— Reply to this email directly, view it on GitHub https://github.com/rivella50/atahualpa/issues/4#issuecomment-2245257094, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACBBDGJAJFB7WY62W4AWS3ZNZK7JAVCNFSM6AAAAABLEMN5WGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBVGI2TOMBZGQ . You are receiving this because you were mentioned.Message ID: @.***>

rivella50 commented 3 months ago

Docker logs say 8.0.28

psychochicken80 commented 3 months ago

We have got the same problem with our page

rivella50 commented 3 months ago

Which php version do both of you use? I will then try to install a wordpress image with that php version and see if i can reproduce the problem.

extremecarver commented 3 months ago

I use 8.2, 8.0 isn't supported anymore. With nginx

On Thu, 25 Jul 2024, 16:50 Valentin Treu, @.***> wrote:

Which php version do both of you use? I will then try to install a wordpress image with that php version and see if i can reproduce the problem.

— Reply to this email directly, view it on GitHub https://github.com/rivella50/atahualpa/issues/4#issuecomment-2250546228, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACBBDBBTPDKHSJNEEUZZWDZOEGD7AVCNFSM6AAAAABLEMN5WGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJQGU2DMMRSHA . You are receiving this because you were mentioned.Message ID: @.***>

rivella50 commented 3 months ago

I was able to run the homepage in another Docker container under php 8.3.9, and the (sub)menus work fine there too. Could it be that you guys have special settings for Menu1 in Design->Atahualpa Theme Options which make submenus don't work correctly anymore?

rivella50 commented 3 months ago

And could you also update to Wordpress version 6.6.1 and verify if the problem still exists?

extremecarver commented 3 months ago

Not really,

Border:solid 3px #FFFFFF Font size: 1.3em Arial, sans-serif Width, 22 Otherwise all default except colour which should not matter

And yeah - gave it another try on 6.6.1 and it's still the same.

On Thu, 25 Jul 2024, 22:07 Valentin Treu, @.***> wrote:

I was able to run the homepage in another Docker container under php 8.3.9, and the (sub)menus work fine there too. Could it be that you guys have special settings for Menu1 in Design->Atahualpa Theme Options which make submenus don't work correctly anymore?

— Reply to this email directly, view it on GitHub https://github.com/rivella50/atahualpa/issues/4#issuecomment-2251307553, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACBBDDEFCJ4QJ6YQC2F6UTZOFLGZAVCNFSM6AAAAABLEMN5WGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJRGMYDONJVGM . You are receiving this because you were mentioned.Message ID: @.***>

extremecarver commented 3 months ago

ata-openmtbmaporg-20240725.txt

Here are my full theme options. But somehow I don't think they are the problem. I kinda defaulted everything and it was still the same (the delete bfa4 key option didn't work and I was too lazy to actually go into the databank after removing any custom code by hand for trying out).

cbennett6008 commented 3 months ago

I have the same problem menu popups stopped working, and seems to have started around the same time with the 6.6 upgrade. I was noticing a couple of jquery errors in the console, and I see this in the WP 6.6 information: https://make.wordpress.org/core/2024/06/25/miscellaneous-developer-changes-in-wordpress-6-6/#jquery-ui-library-update It also appears that I'm running an older version of the theme (.24), so I'll have to try upgrading that to see if that gets me anywhere.

rivella50 commented 3 months ago

Ok, i've installed a brand new Wordpress 6.6.1, added a menu for Menu 1 with one sub menu item and applied Atahualpa 3.7.27. Apparently the menu didn't show the dropdown for the submenu item, only the main menu item. Only when i applied that menu to Menu 1 under Position in Theme and saved it the submenu is shown again and clickable: Screenshot 2024-07-26 at 11 15 17

Could you please ensure that your menu is also applied there? But it's strange that this option seems to have such an impact. When i use one of the standard themes it doesn't matter if that option is selected or not, the submenu items are shown in both cases.

extremecarver commented 3 months ago

Thanks yeah that worked. Just makes it a bit complicated as I have to create that menu first... I used a menu for mobile menu so copying over worked. Basically it renders the Atahualpa Menu options obsolete. At least those about hiding pages or posts... From now on menu needs to be managed by wordpress not by Atahulapa options.

I used duplicate menu plugin to copy over my mobile menu which is a bit different. Sadly some translations weren't copied so some manual action needed on top. But good it works. Likely we should not close this bug as it's a bit unexpected, so people can read the solution more easily.

rivella50 commented 3 months ago

Ok, great to hear. Hopefully this also works for the other reporters of this problem.

If someone is interested: The relevant code can be found here (if no menu location has been chosen): https://github.com/rivella50/atahualpa/blob/e83c9bfd5e9426ad43804a6a5f30e12ab611274e/functions/bfa_header_config.php#L31-L71

MrPhilofaxy commented 3 months ago

Thank you for the menu fix/work around. I've just applied it to about 4 different sites I look after!

All of them now have their drop down menus restored.

Many thanks Steve in France