rivenmedia / riven

Handle your Media Library with ease!
https://rivenmedia.github.io/wiki/
GNU General Public License v3.0
323 stars 47 forks source link

Remove hardcoded username and password #663

Closed lostb1t closed 1 week ago

lostb1t commented 1 month ago

Some providers do not have username and password arguments. This also allows setting other provider specific arguments if needed

Gaisberg commented 1 month ago

Hmm... We only use username and password peoviderconfig for the ones in the settings. Im pretty sure they all require authentication?

lostb1t commented 1 month ago

gestdown (or was it podnapisi) crashes with username and password password.

Gaisberg commented 1 month ago

If you look at the original code we loop over the providers in the settings file, not the default providers (including podnapisi and gestdown). The providers in the settings file require configurations and if the setting is enabled we append the provider along with the configuration to initialization of the subliminal class. Im not sure why you would be having configurations for providers outside of the providers that are supplied by the settings.

lostb1t commented 1 month ago

whats the reason for not having all providers in the settings in the first place?

Gaisberg commented 1 month ago

The default providers are enabled on subliminal by default so I didnt see a reason to add them.