search

rivenmedia / riven

Handle your Media Library with ease!
https://rivenmedia.github.io/wiki/
GNU General Public License v3.0
396 stars 54 forks source link

feat: requests second pass #848

Closed iPromKnight closed 2 weeks ago

iPromKnight commented 2 weeks ago

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago

[!WARNING]

Rate limit exceeded

@iPromKnight has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 59 seconds before requesting another review.

⌛ How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
📥 Commits Reviewing files that changed from the base of the PR and between 29d9f626502160be2b1fc33747551aec3a7500e8 and 93d08b67f485a281d338a11cabf330f31c2ec8c1.

Walkthrough

The changes in this pull request introduce several new exception and request handler classes across multiple API modules, enhancing error handling and request management. Each API class now utilizes a dedicated request handler to encapsulate HTTP request logic, replacing direct session management. Additionally, new enumerations for HTTP methods and response types have been introduced to standardize request handling, improving clarity and maintainability. The overall structure of the API interactions has been refactored for better organization and error management.

Changes

File Path Change Summary
src/program/apis/listrr_api.py Added ListrrAPIError exception and ListrrRequestHandler class. Refactored ListrrAPI to use the new handler for requests, modifying methods validate and get_items_from_Listrr.
src/program/apis/mdblist_api.py Introduced MdblistAPIError exception and MdblistRequestHandler class. Updated MdblistAPI to utilize the new handler for executing requests in methods like validate and my_limits.
src/program/apis/overseerr_api.py Added OverseerrAPIError and OverseerrRequestHandler. Refactored OverseerrAPI to replace direct session calls with the new handler across several methods including validate and get_media_requests.
src/program/apis/plex_api.py Introduced PlexAPIError and PlexRequestHandler. Updated PlexAPI methods to use the new handler for executing requests, enhancing the structure of API communication.
src/program/apis/trakt_api.py Added TraktAPIError and TraktRequestHandler. Refactored TraktAPI to utilize the new handler for executing requests in methods like validate and get_items_from_rss.
src/program/services/content/trakt.py Introduced TraktOAuthRequestHandler. Updated TraktContent to use the new handler for OAuth requests, improving request handling structure.
src/program/services/downloaders/alldebrid.py Updated AllDebridRequestHandler to accept HttpMethod. Refactored AllDebridDownloader to use HttpMethod for API calls, enhancing clarity in request handling.
src/program/services/downloaders/realdebrid.py Modified RealDebridRequestHandler to accept HttpMethod. Updated RealDebridDownloader methods to use HttpMethod for consistency in API calls.
src/program/services/scrapers/comet.py Introduced ScraperRequestHandler. Updated Comet methods to use the new handler for executing requests, enhancing error handling and request management.
src/program/services/scrapers/jackett.py Updated Jackett to utilize ScraperRequestHandler for HTTP requests, improving error logging and request handling structure.
src/program/services/scrapers/knightcrawler.py Modified Knightcrawler to use ScraperRequestHandler for HTTP requests, enhancing modularity in request handling.
src/program/services/scrapers/mediafusion.py Introduced ScraperRequestHandler. Updated Mediafusion methods to use the new handler for executing requests, improving modularity and error handling.
src/program/services/scrapers/orionoid.py Updated Orionoid to utilize ScraperRequestHandler for executing requests, enhancing request handling structure.
src/program/services/scrapers/prowlarr.py Replaced session with request_handler in Prowlarr, updating methods to utilize the new handler for HTTP requests, improving clarity in request handling.
src/program/services/scrapers/shared.py Added ScraperRequestHandler class. Updated imports and introduced new functionality for managing scraper requests.
src/program/services/scrapers/torbox.py Modified TorBoxScraper to use ScraperRequestHandler for HTTP requests, enhancing error handling and request management.
src/program/services/scrapers/torrentio.py Updated Torrentio to utilize ScraperRequestHandler for executing requests, improving consistency in request handling.
src/program/services/scrapers/zilean.py Introduced ScraperRequestHandler. Updated Zilean methods to use the new handler for executing requests, enhancing modularity and error handling.
src/program/services/updaters/emby.py Added EmbyRequestHandler. Refactored EmbyUpdater methods to use the new handler for executing requests, improving request handling structure.
src/program/services/updaters/jellyfin.py Introduced JellyfinRequestHandler. Updated JellyfinUpdater methods to utilize the new handler for executing requests, enhancing error handling and request management.
src/program/utils/request.py Added HttpMethod and ResponseType enums. Refactored BaseRequestHandler and ResponseObject to utilize these enums, enhancing request handling and response processing.

Poem

In the code where rabbits play,
New handlers hop in, bright as day.
Errors caught with gentle grace,
Requests now flow in a cozy space.
With every call, a leap we take,
For smoother paths, our code will make! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
iPromKnight commented 2 weeks ago

@CodiumAI-Agent /review

CodiumAI-Agent commented 2 weeks ago

PR Reviewer Guide 🔍

(Review updated until commit https://github.com/rivenmedia/riven/commit/93d08b67f485a281d338a11cabf330f31c2ec8c1)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Code Duplication
The `BaseRequestHandler` class has been subclassed multiple times across different modules with similar initialization logic. Consider refactoring to reduce duplication and centralize common functionality. Exception Handling
The exception handling in the request handlers should be reviewed to ensure that all potential error cases are appropriately managed and logged, providing clear feedback for API consumers. Security Concerns
Ensure that sensitive data such as API keys are securely handled and not exposed through logs or error messages.
CodiumAI-Agent commented 2 weeks ago

Persistent review updated to latest commit https://github.com/rivenmedia/riven/commit/93d08b67f485a281d338a11cabf330f31c2ec8c1