rivenmedia / riven

Handle your Media Library with ease!
https://rivenmedia.github.io/wiki/
GNU General Public License v3.0
421 stars 57 forks source link

[BUG] tt5321682 causes a crash #97

Closed activ closed 10 months ago

activ commented 11 months ago

Wit the help of Gb I added extra logging and found that tt5321682 crashes iceberg consitently.

[2023-12-29 12:04:51 | DEBUG] <trakt._map_item_from_data> - tt5321682
Iceberg  | Traceback (most recent call last):
Iceberg  |   File "/iceberg/backend/main.py", line 22, in <module>
Iceberg  |     app.program = Program()
Iceberg  |                   ^^^^^^^^^
Iceberg  |   File "/iceberg/backend/program/__init__.py", line 59, in __init__
Iceberg  |     Content(self.media_items),  # Content must be first
Iceberg  |     ^^^^^^^^^^^^^^^^^^^^^^^^^
Iceberg  |   File "/iceberg/backend/program/content/__init__.py", line 28, in __init__
Iceberg  |     service.run()
Iceberg  |   File "/iceberg/backend/program/content/overseerr.py", line 40, in run
Iceberg  |     container = self.updater.create_items(new_items)
Iceberg  |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Iceberg  |   File "/iceberg/backend/program/updaters/trakt.py", line 27, in create_items
Iceberg  |     item = self._create_item(imdb_id)
Iceberg  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^
Iceberg  |   File "/iceberg/backend/program/updaters/trakt.py", line 43, in _create_item
Iceberg  |     item = create_item_from_imdb_id(imdb_id)
Iceberg  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Iceberg  |   File "/iceberg/backend/program/updaters/trakt.py", line 131, in create_item_from_imdb_id
Iceberg  |     return _map_item_from_data(data, media_type)
Iceberg  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Iceberg  |   File "/iceberg/backend/program/updaters/trakt.py", line 93, in _map_item_from_data
Iceberg  |     item["number"] = getattr(data, "number")
Iceberg  |                      ^^^^^^^^^^^^^^^^^^^^^^^
Iceberg  | AttributeError: 'types.SimpleNamespace' object has no attribute 'number'
dreulavelle commented 11 months ago

Iceberg doesnt handle Specials very well :/

dreulavelle commented 11 months ago

https://torrentio.strem.fun/qualityfilter=other,scr,cam,unknown/stream/series/tt5321682:1:1.json

Episodes show up on Torrentio under that imdb id. Really weird its throwing an error. Was old pkl files involved?

activ commented 11 months ago

Nope, no old pkl. Persisted even after removing the pkl’s. I did not try adding it again after removing overseerr’s database though, maybe something was wrong with it on the overseer side?

dreulavelle commented 11 months ago

This needs to get looked at @Gaisberg

We suck at retrieving specials for items.. actually this could be probably solved if we switched to keyword queries on Jackett.

dreulavelle commented 10 months ago

This has been fixed in the latest update. Adds the item correctly now.