river-styx / river-styx.core

Apache License 2.0
2 stars 3 forks source link

Logging framework #4

Open dmportella opened 8 years ago

dmportella commented 8 years ago

Logging must be added. should support logging to file should support logging to custom endpoint (including queue - publishing)

tegud commented 8 years ago

Guess the real question is do we go with something like standard like winston, or specify an interface people can plug their own loggers into?

My preference would be the latter, it would feel a bit odd for a framework npm to enforce a choice of logging npm.

tegud commented 8 years ago

Joe makes a good point, maybe it's all events.

e.g. client.on('connection-made', (connectionDetails) => { // handler });

dmportella commented 8 years ago

yeah i was going to suggest that we should use events to to allow some one to hook it up it.

joe should join the conversation here

dmportella commented 8 years ago

@tegud i am also in the later group i rather make it so people can plug in their own logging...

tegud commented 8 years ago

So events it is, no logging needed

dmportella commented 8 years ago

aye that seems the best way just use this ticket to add the events if any is needed