search

riverbed / steelscript

SteelScript is a collection of libraries and scripts in Python for interacting with Riverbed solutions and appliances, and other network infrastructure devices
https://support.riverbed.com/apis/steelscript
Other
14 stars 10 forks source link

Update setup.py #12

Closed jkraenzle closed 3 years ago

jkraenzle commented 4 years ago

Update the requests version to use 2.25.0 so it includes urllib3 1.26.2, as urllib3 1.24.0 has known security issues.

gwenblum commented 4 years ago

Thanks, can you please indicate what kind of test worked for you with this change? If you have any sample, you can just add them to the PR in a subfolder inside /tests

jkraenzle commented 4 years ago

I used AppResponse scripts that I had written specific to customers for downloading packets, running reports for specific Host Groups, and running reports for filtered conversations. As ech script logs in and runs different REST APIs, the Python requests library was used in all of them that ran into no issues. This was not an extensive test, but confirmed it worked normally for a more complex script. I do not know what type of formal unit tests you would want to create to ensure it does not affect NetProfiler and other products.

From: Gwen Blum notifications@github.com Sent: Thursday, November 19, 2020 4:20 PM To: riverbed/steelscript steelscript@noreply.github.com Cc: Joseph Kraenzle Joseph.Kraenzle@riverbed.com; Author author@noreply.github.com Subject: [EXTERNAL] Re: [riverbed/steelscript] Update setup.py (#12)

Thanks, can you please indicate what kind of test worked for you with this change? If you have any sample, you can just add them to the PR in a subfolder inside /tests

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/riverbed/steelscript/pull/12*issuecomment-730643384__;Iw!!LmzIUXm5cg!F6AOoP2g-pbMDRtVaS_GmzESVkQu_HI5TAOvdRdBhaEpX8nCTrrmbrPolRN_qjL1ww$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ALXOZZTROCSSD2KK5GEBFELSQWDXFANCNFSM4T3OV2KQ__;!!LmzIUXm5cg!F6AOoP2g-pbMDRtVaS_GmzESVkQu_HI5TAOvdRdBhaEpX8nCTrrmbrPolRMhV8EnuA$.

gwenblum commented 3 years ago

Thanks the compatilibity checks with recent urllib3 and requests are useful for the test-plans. As for the code, currently it is already a >= that allows steelscript to be deployed with any newer versions of urlib (or the latest), we can keep as it is for now.