search

rivergillis / update-pocket

An all-in-one tool to update your Analogue Pocket firmware and openFPGA cores!
60 stars 9 forks source link

Comments-the-tree integration failing #13

Open rivergillis opened 2 years ago

rivergillis commented 2 years ago

See https://github.com/rivergillis/update-pocket/actions/runs/3153160059/jobs/5129295509 for an example of a failure job, integration was added in #10

rivergillis commented 2 years ago

Looks to be related to https://github.com/thollander/actions-comment-pull-request/issues/30, perhaps since I had to rebase on someone elses fork?

If so, seems like a non-issue. Will verify with the next PR

neil-morrison44 commented 2 years ago

Might depend on who has caused the workflow to run - with it only running fine when it’s the repo owner.

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run

probably need to have workflow 1 store the tree (& PR id) as an artefact then use another workflow (triggered via workflow_run to download that artefact & do the comment) - sort of similar to the last example on that link