search

rivernews / appl-tracky-spa

An Application Tracking System to help job finders ease their out-of-control spreadsheet use tracking every job application record.
https://appl-tracky.shaungc.com
1 stars 0 forks source link

Auth request State is not correct / Logout button blocked (disabled by waiting for all data fetching) #43

Closed rivernews closed 3 years ago

rivernews commented 5 years ago

When logged in, auth request state still remains "requesting". This affects the logout button disable state in profile page.

It seems like the state is same as the data request state. Once all data is loaded, the auth request state becomes "complete".

rivernews commented 5 years ago

The current auth.RequestStatus is more like a global status for all data fetching. It is used for loading indicator, which is ok, but should be moved out of selector store.auth to somewhere else.

rivernews commented 5 years ago

For user profile "Logout" button, we will just show it w/o conditioning on requesting status. Since at the timing of accessing profile page, it's an internal page which already indicates that login process is finished.

⚠️ After logout button pressed - ideally no need to wait for request status, just interrupt existing requests. However, we'll have to cancel those ongoing sagas for data fetching. Cancelling saga is something we'll have to figure out how to do it properly.

rivernews commented 3 years ago

Not sure if this is already resolved or not. Closing now, will create new one if any problem emerges.