CKEditor link does not open in new tab when in read only mode

rivernews commented 4 years ago

Change: Set addTargetToExternalLinks to true.

Behavior:

When using balloon editor, nothing changed for link:
- When in edit mode, the link always opens in external page, regardless of whether url starts with //, http://, https:// or not. Even relative path like /what/ will open in external window.
- When in read only mode, link will always open in the same window, regardless of whether the url is a external or internal link.

Expected:

When in edit mode, the link should open in the same window when is internal url
When in read only mode, the link should open in external window when link is external url.

rivernews commented 4 years ago

Using the automatic approach with decorator addTargetToExternalLinks in the example solved the issue

rivernews commented 4 years ago

Strategy

https, http, // --> treat as external link
/.. --> treat as internal link
google.com --> want to treat as external link, but <a> will be auto-converted by the browser into a internal link. See this SO post