rivernews / slack-middleware-server

This server act as a middleware to communicate with Slack API.
1 stars 1 forks source link

Individual retry job support during s3 job session #72

Closed rivernews closed 4 years ago

rivernews commented 4 years ago

Currently when job fail, s3 job will keep moving forward.

The failed job will be shown in bull board. There's retry-all button. If we retry supervisor job, it will be queued again and run.

However, in what order will these retry jobs be inserted into the queue? Likely at last.

However, these manuall-retrying jobs are not managed by s3 job anymore. The S3 job Promise.all will not wait for these jobs. These jobs can still run, until the original s3 job finalized, and start scaling down.

Yes, when s3 scales down selenium stack, these jobs will fail becuase their java scraper are destroyed. They'll probably stay up for a while, waiting for scraper to report progress. And then die out by timeout.

Ideas

rivernews commented 4 years ago

Solved by waiting and polling any supervisor job in progress, and once concurrency falls back to 0, the s3 finalizer scales down all nodes. Meanwhile #76 issue seems no longer occur as well.