Let last splited job total be the right actual value, not the org total

rivernews / slack-middleware-server

This server act as a middleware to communicate with Slack API.

1 stars 1 forks source link

Closed rivernews closed 4 years ago

rivernews commented 4 years ago

As title. Should be small fix.

Will improve false alarming of warning low went through rate, and identify a real incident in scraping.

rivernews commented 4 years ago

Previous water meter price is at $2.87. We are going to test the entire suite again, see if the last job split fix affects anything.

Workflow

Terraform provisioning k8s cluster on CircleCI at branch release: took 11m 24s
Manually running auto apply script in SLK repo. (around a minute or so)
Access SLK and start s3 job there. Finger crossed.

rivernews commented 4 years ago

Needs to fix something

[x] s3 job, only do Math.min on total in last job; other middle jobs no need to do so otherwise will get wrong total number
[x] decreases dispatch interval

rivernews commented 4 years ago

The issue no longer emerged after fix.