riverqueue / river

Fast and reliable background jobs in Go
https://riverqueue.com
Mozilla Public License 2.0
2.86k stars 68 forks source link

Corrected wording of 'will' to 'won't' #389

Closed jazzopaul closed 1 month ago

jazzopaul commented 1 month ago

Wording for snooze description appears to be incorrect.

bgentry commented 1 month ago

@jazzopaul the description is correct as described in the docs. As of now, snoozing a job will increment its max attempts because the job fetch query will always increment the attempts of any jobs fetched for work.

We have talked about potentially altering this behavior (see https://github.com/riverqueue/river/issues/378#issuecomment-2140904423). It would be a breaking change but might be worthwhile at this stage for the sake of a less confusing behavior (particularly around how custom retry policies calculate their backoff).