search

riverqueue / river

Fast and reliable background jobs in Go
https://riverqueue.com
Mozilla Public License 2.0
2.66k stars 65 forks source link

Intermittently failing test: `TestPeriodicJobEnqueuer/AddAfterStart` #409

Closed brandur closed 19 hours ago

brandur commented 1 week ago 
--- FAIL: TestPeriodicJobEnqueuer (0.00s)
    --- FAIL: TestPeriodicJobEnqueuer/AddAfterStart (0.10s)
        periodic_job_enqueuer_test.go:373: 
                Error Trace:    /home/runner/work/river/river/internal/maintenance/periodic_job_enqueuer_test.go:87
                                            /home/runner/work/river/river/internal/maintenance/periodic_job_enqueuer_test.go:373
                Error:          "[0xc0005bf560 0xc0005bf680]" should have 1 item(s), but has 2
                Test:           TestPeriodicJobEnqueuer/AddAfterStart
                Messages:       Expected to find exactly 1 job(s) of kind: periodic_job_500ms_start, but found 2
FAIL

https://github.com/riverqueue/river/actions/runs/9727144459/job/26846367325?pr=408

brandur commented 4 days ago

Damn it, these are still happening. I don't even.

brandur commented 2 days ago

I think the start/stop fix that came in as part of #430 finally cracked this one. I've now done 72 total test runs and haven't gotten a single failure. Going to optimistically re-close this.

brandur commented 2 days ago

NM, now seeing it again. Wtf.