search

riverqueue / river

Fast and reliable background jobs in Go
https://riverqueue.com
Mozilla Public License 2.0
3.34k stars 89 forks source link

docs: riverpro missing line type workflows -> workflow #546

Closed krhubert closed 3 weeks ago

krhubert commented 3 weeks ago

Hi,

When I run cli with --line workflows it panics.

riverpro migrate-up --database-url  "postgres://postgres:@localhost:5432/postgres" --line workflows
panic: migration line does not exist: workflows

But with --line workflow all is good

riverpro migrate-up --database-url  "postgres://postgres:@localhost:5432/postgres" --line workflow

Links with typos

https://riverqueue.com/docs/pro/go-proxy#installing-in-ci-and-build-environments https://riverqueue.com/docs/pro/getting-started#running-pro-migrations

brandur commented 3 weeks ago

Thanks Hubert!

Wow, believe it or not, we've had multiple people run through those steps already, but you're the first to report the problem to us :/

I just pushed a fix. We should really also have some basic Levenshtein distance check that'd be able to detect a one letter difference and suggest a correction too. I'll look into that separately.

Please don't hesitate to open any more bug reports if you find other problems!

krhubert commented 3 weeks ago

Sure, I was quite surprised that nobody ran into trouble with this one. Awesome it is fixed so fast. I'll open issues as they raise. I actually have one more already.

brandur commented 3 weeks ago

Going to try and do one other small follow up here to suggest alternatives when a migration line is found to be non-existent in #558.