Closed semanser closed 2 months ago
Odd, I could have sworn we had tests for this case. Maybe it was lost during a refactor somehow 🤔 thank you for submitting, will just need to look to see if I can figure out whether we have some existing broken tests for this or if it was simply never covered.
@semanser would you mind signing off on the project’s CLA as well? https://github.com/riverqueue/rivercla
@semanser Could you take a look at the lint failures on this one? It seems like you might be able to get away without adding a TestJobArgs
for the new test case.
@brandur done!
@semanser I brought over this PR into #572, added a lint fix for a pre-existing lint issue, and added additional high level coverage at the client level to be confident this doesn't break in the future. Thank you again for the fix! :v:
This commit fixes an issue with the PerioridJobConstructor ignoring the return value. According to the docs, we should ignore the job is nil is returned.
Before:
After: