search

riverqueue / river

Fast and reliable background jobs in Go
https://riverqueue.com
Mozilla Public License 2.0
3.37k stars 89 forks source link

flaky StopAndCancel test in CI #65

Closed bgentry closed 10 months ago

bgentry commented 10 months ago

GitHub Actions continues to surprise us with timing issues @brandur:

client_test.go:546: Waiting on job to be done
        client_test.go:559: 
                Error Trace:    /home/runner/work/river/river/client_test.go:559
                Error:          Max difference between 2023-11-23 18:02:54.632264664 +0000 UTC m=+0.706377072 and 2023-11-23 18:02:54.531149022 +0000 UTC m=+0.6052614[30](https://github.com/riverqueue/river/actions/runs/6973035679/job/18976333126#step:8:31) allowed is 100ms, but difference was 101.115642ms
                Test:           Test_Client_StopAndCancel/jobs_in_progress,_only_completing_when_context_is_canceled
brandur commented 10 months ago

1 ms over budget. Seems like the tolerance on that might be a little too tight.