fix(doc): fix docker command

riverqueue / riverui

A web interface for River, fast and reliable background jobs in Go.

https://ui.riverqueue.com/

Mozilla Public License 2.0

43 stars 3 forks source link

fix(doc): fix docker command #69

Closed agirot closed 5 days ago

agirot commented 5 days ago

typo: options must be passed before image not after
Add -p 8080:8080 to have a working demo command

Thank you for your amazing work ! ❤️

bgentry commented 5 days ago

Thank you for these fixes! I think we also need to make equivalent fixes in the base README.md—this docs/README.md is a variant for Go docs, right @brandur ?

brandur commented 5 days ago

Nah, I think we're good on this one Blake. docs/README.md is the main README (GitHub will read out of it) and unlike the main project, riverui doesn't have a doc.go yet (we should add one once the handler is ready though).

brandur commented 5 days ago

@bgentry Going to merge this, but do you want to look at the Docker failure here? It's failing with a 403 on push, probably because a 3rd party contributor doesn't have access to the image repo. (Should a branch like this even be pushing to the repo even if the person does have access?)