search

riverrun / bcrypt_elixir

Bcrypt password hashing for Elixir
Other
162 stars 26 forks source link

Add a note about compiling in Docker #17

Closed macbem closed 5 years ago

macbem commented 5 years ago

I've chosen to add this paragraph, because I found this info quite hard to find anywhere. I've also added it to Comeonin docs so that it'll be easier to find, but I think that it might be useful to have it both in bcrypt readme and Comeonin docs, because some people might want to use them separately.

riverrun commented 5 years ago

There is a note about using Comeonin / Bcrypt with docker here - can you look at the last two comments from https://github.com/NobbZ and see to what extent they agree with the notes you have written.

macbem commented 5 years ago

@riverrun I was just about to fix my PR with a note about .dockerignore, because I noticed what NobbZ pointed out - the failure was happening because of conflicts between local builds and Docker container builds.

I changed my pull request appropriately and added a note about using .dockerignore, together with a list of directories that you have to add there. I believe that this PR is now correct and ready to be merged - I'm using those guidelines in my project in an image based on elixir:alpine and everything is working fine.

riverrun commented 5 years ago

Great! Thanks for your help.