riverrun / genxword

Crossword generator written in Python.
GNU General Public License v3.0
162 stars 40 forks source link

Hebrew crossword #3

Closed tuvia closed 11 years ago

tuvia commented 11 years ago

Hi, thank you for this wonderful program.

I'm trying to make a hebrew crossword, I used the python3 version which allowed me to write the words in hebrew. However, when genxword generated the crossword, it did it in a reverse order.

To explain: hebrew language is written and read from right to left. So genxword should generate the crossword taking into account that the vertical words should go from top to bottom (as they already do, that's fine) and the horizontal words should go from right to left.

That is, to make it more graphical: the word HELLO, if genxword thinks should go in the horizontal way, should be put OLLEH. However in the vertical way it should treat it as it does right now, no change needed.

Do you think this is possible? I'd love to help doing it but I'm not an experienced python programmer, maybe if you give me some tips of where should this be taken care of, I can try to see and solve it... but I'm just a computer loving rabbi...

Thank you!!

Rabbi Tuvia Serber.

riverrun commented 11 years ago

Hi, I'll look into it. I'd be glad to make it work properly in other languages. I presume that it would also help you if you could write the words and clues from right-to-left. Is that correct? Dave

tuvia commented 11 years ago

Hi, I'm so happy you answered! You're right, it would also help if you can write the words and clues in hebrew. However, please, don't make it exclusive. That means, I use the crosswords to teach words in hebrew, so, it would also be great if you can, for ex. write the words in hebrew but the clues in spanish!

Thank you so much, Tuvia.

riverrun commented 11 years ago

Hi, I've uploaded a version that gives you an option to produce crosswords with right-to-left text to the develop branch. Can you test it and let me know if it works? You will find the right-to-left option in the 'Crossword' drop-down menu. It's an option you can toggle on and off. Dave

tuvia commented 11 years ago

Very good! I'm sending you a test crossword. The end result is great, however, when it shows you the options (I'm sending a picture to see what I'm talking about), it does it backwards. However, when it finally saves the crossword, it does it correctly. Please compare the third word in the words list with the same word in the image, you'll see the letters backwards. The correct onw is the one in the words list (and, again, it comes out fine in the end result of the crossword).

Just a side note, the PDF with the keys comes out wrong, with little boxes instead of the correct letters. Probably a font problem?

Great job!!! Thank you!!!!

Rabino Tuvia Serber

Beit Jabad La Plata

www.jabadlaplata.org.ar

On Thu, Apr 25, 2013 at 11:08 PM, David Whitlock notifications@github.comwrote:

Hi, I've uploaded a version that gives you an option to produce crosswords with right-to-left text to the develop branch. Can you test it and let me know if it works? You will find the right-to-left option in the 'Crossword' drop-down menu. It's an option you can toggle on and off. Dave

— Reply to this email directly or view it on GitHubhttps://github.com/riverrun/genxword/issues/3#issuecomment-17051809 .

תורה la bilbia כהן sacerdote פרשה la sección de la semana

tuvia commented 11 years ago

just another side note: maybe you can give an option to change the default "Across" and "down", words, since in other languages they differ...

Thank you!

Rabino Tuvia Serber

Beit Jabad La Plata

www.jabadlaplata.org.ar

On Thu, Apr 25, 2013 at 11:08 PM, David Whitlock notifications@github.comwrote:

Hi, I've uploaded a version that gives you an option to produce crosswords with right-to-left text to the develop branch. Can you test it and let me know if it works? You will find the right-to-left option in the 'Crossword' drop-down menu. It's an option you can toggle on and off. Dave

— Reply to this email directly or view it on GitHubhttps://github.com/riverrun/genxword/issues/3#issuecomment-17051809 .

tuvia commented 11 years ago

sorry to send you so many mails... looking a the image, you can see that it's flipped. The short word appears at the begginig, while in the crowwrod is at the end. You just have to flip it.

Thank you,

Rabino Tuvia Serber

Beit Jabad La Plata

www.jabadlaplata.org.ar

On Thu, Apr 25, 2013 at 11:28 PM, Beit Jabad La Plata < rabtuvia@jabadlaplata.org.ar> wrote:

just another side note: maybe you can give an option to change the default "Across" and "down", words, since in other languages they differ...

Thank you!

Rabino Tuvia Serber

Beit Jabad La Plata

www.jabadlaplata.org.ar

On Thu, Apr 25, 2013 at 11:08 PM, David Whitlock <notifications@github.com

wrote:

Hi, I've uploaded a version that gives you an option to produce crosswords with right-to-left text to the develop branch. Can you test it and let me know if it works? You will find the right-to-left option in the 'Crossword' drop-down menu. It's an option you can toggle on and off. Dave

— Reply to this email directly or view it on GitHubhttps://github.com/riverrun/genxword/issues/3#issuecomment-17051809 .

riverrun commented 11 years ago

I'll have another look at it and let you know when I've sorted that problem out. Dave

riverrun commented 11 years ago

Hi, I think I've solved both problems: the display after you calculate the crossword and the fonts on the pdf file. I've pushed it to the develop branch, so if you could test it for me and let me know if it works, that would be great. Thanks, Dave

tuvia commented 11 years ago

Hi Dave, yhank you for taking your time for this!

I'm sending you an image of the crossword generaion, the words are in the correct order, whowever, it doesn't show the grid. For me it's not a problem.

The saving of the crossword doesn't workk for me. This is the Traceback of the error:

Traceback (most recent call last): File "/usr/local/lib/python3.2/dist-packages/genxword3/gui.py", line 349, in save_xword exp.create_files(self.xwordname, self.saveformat, self.RTL, True) File "/usr/local/lib/python3.2/dist-packages/genxword3/calculate.py", line 271, in create_files self.export_pdf(name, '_grid.pdf', RTL) File "/usr/local/lib/python3.2/dist-packages/genxword3/calculate.py", line 245, in export_pdf self.draw_img(name, context, 28, xoffset, 80, RTL) File "/usr/local/lib/python3.2/dist-packages/genxword3/calculate.py", line 204, in draw_img self.draw_letters(str(word[5]), context, x+3, y+2, 'monospace 6') File "/usr/local/lib/python3.2/dist-packages/genxword3/calculate.py", line 208, in draw_letters layout = PangoCairo.create_layout(context) File "/usr/lib/python3/dist-packages/gi/types.py", line 43, in function return info.invoke(_args, *_kwargs) KeyError: 'could not find foreign type Context'

Same error appears on all save options (A4 pdf, letter PDF, png and SVG), just differs on some function names, but the end error is the same.

It produced an empty grid, I'm attaching files.

Thank you!!!

Rabino Tuvia Serber

Beit Jabad La Plata

www.jabadlaplata.org.ar

On Wed, May 1, 2013 at 8:45 PM, David Whitlock notifications@github.comwrote:

Hi, I think I've solved both problems: the display after you calculate the crossword and the fonts on the pdf file. I've pushed it to the develop branch, so if you could test it for me and let me know if it works, that would be great. Thanks, Dave

— Reply to this email directly or view it on GitHubhttps://github.com/riverrun/genxword/issues/3#issuecomment-17313260 .

שביעית El séptimo año מצוה Un precepto יובל El año número cincuenta רבית Intereses עבד Sirviente קרבן Ofrenda מצות Preceptos תורה La bilbia שבת El séptimo día שנה Año, en hebreo חמשים Cincuenta ישראל La Tierra de ____ משכן El templo en el desierto אברהם El primer patriarca יצחק El segundo patriarca יעקב El tercer patriarca שרה La primer matriarca רבקה La segunda matriarca רחל La esposa preferida de Iaacov לאה La primer esposa de Iaacov בהר La primer parashá de esta semana בחוקותי La segunda parashá de esta semana ויקרא Tercer libro de la Torá בראשית Primer libro de la Torá שמות Segundo libro de la Torá במדבר Cuarto libro de la Torá דברים Quinto libro de la Torá

tuvia commented 11 years ago

sounds like a problem with the font... I'm including a few nice and normal hebrew fonts you can embedd in the installation process, or something like that. Regards,

Rabino Tuvia Serber

Beit Jabad La Plata

www.jabadlaplata.org.ar

On Wed, May 1, 2013 at 9:10 PM, Beit Jabad La Plata < rabtuvia@jabadlaplata.org.ar> wrote:

Hi Dave, yhank you for taking your time for this!

I'm sending you an image of the crossword generaion, the words are in the correct order, whowever, it doesn't show the grid. For me it's not a problem.

The saving of the crossword doesn't workk for me. This is the Traceback of the error:

Traceback (most recent call last): File "/usr/local/lib/python3.2/dist-packages/genxword3/gui.py", line 349, in save_xword exp.create_files(self.xwordname, self.saveformat, self.RTL, True) File "/usr/local/lib/python3.2/dist-packages/genxword3/calculate.py", line 271, in create_files self.export_pdf(name, '_grid.pdf', RTL) File "/usr/local/lib/python3.2/dist-packages/genxword3/calculate.py", line 245, in export_pdf self.draw_img(name, context, 28, xoffset, 80, RTL) File "/usr/local/lib/python3.2/dist-packages/genxword3/calculate.py", line 204, in draw_img self.draw_letters(str(word[5]), context, x+3, y+2, 'monospace 6') File "/usr/local/lib/python3.2/dist-packages/genxword3/calculate.py", line 208, in draw_letters layout = PangoCairo.create_layout(context) File "/usr/lib/python3/dist-packages/gi/types.py", line 43, in function return info.invoke(_args, *_kwargs) KeyError: 'could not find foreign type Context'

Same error appears on all save options (A4 pdf, letter PDF, png and SVG), just differs on some function names, but the end error is the same.

It produced an empty grid, I'm attaching files.

Thank you!!!

Rabino Tuvia Serber

Beit Jabad La Plata

www.jabadlaplata.org.ar

On Wed, May 1, 2013 at 8:45 PM, David Whitlock notifications@github.comwrote:

Hi, I think I've solved both problems: the display after you calculate the crossword and the fonts on the pdf file. I've pushed it to the develop branch, so if you could test it for me and let me know if it works, that would be great. Thanks, Dave

— Reply to this email directly or view it on GitHubhttps://github.com/riverrun/genxword/issues/3#issuecomment-17313260 .

tuvia commented 11 years ago

Rabino Tuvia Serber

Beit Jabad La Plata

www.jabadlaplata.org.ar

On Wed, May 1, 2013 at 9:18 PM, Beit Jabad La Plata < rabtuvia@jabadlaplata.org.ar> wrote:

sounds like a problem with the font... I'm including a few nice and normal hebrew fonts you can embedd in the installation process, or something like that. Regards,

Rabino Tuvia Serber

Beit Jabad La Plata

www.jabadlaplata.org.ar

On Wed, May 1, 2013 at 9:10 PM, Beit Jabad La Plata < rabtuvia@jabadlaplata.org.ar> wrote:

Hi Dave, yhank you for taking your time for this!

I'm sending you an image of the crossword generaion, the words are in the correct order, whowever, it doesn't show the grid. For me it's not a problem.

The saving of the crossword doesn't workk for me. This is the Traceback of the error:

Traceback (most recent call last): File "/usr/local/lib/python3.2/dist-packages/genxword3/gui.py", line 349, in save_xword exp.create_files(self.xwordname, self.saveformat, self.RTL, True) File "/usr/local/lib/python3.2/dist-packages/genxword3/calculate.py", line 271, in create_files self.export_pdf(name, '_grid.pdf', RTL) File "/usr/local/lib/python3.2/dist-packages/genxword3/calculate.py", line 245, in export_pdf self.draw_img(name, context, 28, xoffset, 80, RTL) File "/usr/local/lib/python3.2/dist-packages/genxword3/calculate.py", line 204, in draw_img self.draw_letters(str(word[5]), context, x+3, y+2, 'monospace 6') File "/usr/local/lib/python3.2/dist-packages/genxword3/calculate.py", line 208, in draw_letters layout = PangoCairo.create_layout(context) File "/usr/lib/python3/dist-packages/gi/types.py", line 43, in function return info.invoke(_args, *_kwargs) KeyError: 'could not find foreign type Context'

Same error appears on all save options (A4 pdf, letter PDF, png and SVG), just differs on some function names, but the end error is the same.

It produced an empty grid, I'm attaching files.

Thank you!!!

Rabino Tuvia Serber

Beit Jabad La Plata

www.jabadlaplata.org.ar

On Wed, May 1, 2013 at 8:45 PM, David Whitlock notifications@github.comwrote:

Hi, I think I've solved both problems: the display after you calculate the crossword and the fonts on the pdf file. I've pushed it to the develop branch, so if you could test it for me and let me know if it works, that would be great. Thanks, Dave

— Reply to this email directly or view it on GitHubhttps://github.com/riverrun/genxword/issues/3#issuecomment-17313260 .

riverrun commented 11 years ago

Thanks for letting me know. I'll look at it again and let you know when it's ready to test again. Dave

riverrun commented 11 years ago

Could you let me know what version of Linux (and / or what version of Pango) you're using. That might help me debug this.

riverrun commented 11 years ago

And do you have python3-gi-cairo installed?

tuvia commented 11 years ago

I'm using Xubuntu 12.04 with all the updates. I include the result of uname -ra dpkg -l grep | pango dpkg -l grep python3

Let me know if you need more infor or whether you want me to test installing any package.

Thanks!

Rabino Tuvia Serber

Beit Jabad La Plata

www.jabadlaplata.org.ar

On Fri, May 3, 2013 at 2:31 AM, David Whitlock notifications@github.comwrote:

And do you have python3-gi-cairo installed?

— Reply to this email directly or view it on GitHubhttps://github.com/riverrun/genxword/issues/3#issuecomment-17379193 .

riverrun commented 11 years ago

Hi, Can you check to see if you have python3-gi-cairo installed? If it's not installed, install it and try genxword3 again. Thanks, Dave

tuvia commented 11 years ago

Works great!! Thank you so much!! I had to install the package for it to work, maybe you can add it as a dependency. Thank you again so much. I include a testing corssword, just for the records!

Rabino Tuvia Serber

Beit Jabad La Plata

www.jabadlaplata.org.ar

On Fri, May 3, 2013 at 8:54 PM, David Whitlock notifications@github.comwrote:

Hi, Can you check to see if you have python3-gi-cairo installed? If it's not installed, install it and try genxword3 again. Thanks, Dave

— Reply to this email directly or view it on GitHubhttps://github.com/riverrun/genxword/issues/3#issuecomment-17424194 .

שביעית El séptimo año מצוה Un precepto יובל El año número cincuenta רבית Intereses עבד Sirviente קרבן Ofrenda מצות Preceptos תורה La bilbia שבת El séptimo día שנה Año, en hebreo חמשים Cincuenta ישראל La Tierra de ____ משכן El templo en el desierto אברהם El primer patriarca יצחק El segundo patriarca יעקב El tercer patriarca שרה La primer matriarca רבקה La segunda matriarca רחל La esposa preferida de Iaacov לאה La primer esposa de Iaacov בהר La primer parashá de esta semana בחוקותי La segunda parashá de esta semana ויקרא Tercer libro de la Torá בראשית Primer libro de la Torá שמות Segundo libro de la Torá במדבר Cuarto libro de la Torá דברים Quinto libro de la Torá

riverrun commented 11 years ago

That's great! At the moment, I'm working on a new version, which will automatically detect right-to-left text (so you will not see a 'Right-to-left' text option in the 'Crossword' menu). That should be ready in a few days. Also, the Python 2.7 version will be able to display more languages, including right-to-left text. Again, that will be ready in a few days. Thanks for your help in making this program better, Dave

tuvia commented 11 years ago

Let me know if you need me to test it. I'll do it gladly. Thanks!

Rabino Tuvia Serber

Beit Jabad La Plata

www.jabadlaplata.org.ar

On Sun, May 5, 2013 at 9:03 PM, David Whitlock notifications@github.comwrote:

That's great! At the moment, I'm working on a new version, which will automatically detect right-to-left text (so you will not see a 'Right-to-left' text option in the 'Crossword' menu). That should be ready in a few days. Also, the Python 2.7 version will be able to display more languages, including right-to-left text. Again, that will be ready in a few days. Thanks for your help in making this program better, Dave

— Reply to this email directly or view it on GitHubhttps://github.com/riverrun/genxword/issues/3#issuecomment-17461946 .