Allow otp_secret of 64 characters

riverrun / one_time_pass_ecto

No longer maintained - One-time password library with Ecto support (for Elixir)

55 stars 9 forks source link

Allow otp_secret of 64 characters #2

Closed zwippie closed 6 years ago

zwippie commented 6 years ago

This PR allows the otp_secret to be 64 characters long.

My use-case: I'm in the process of converting an app that requires a secret to be that long. The change is minimal, I don't think it does any harm security-wise?

mix.lock with some updated dependencies is included in this PR. Dunno if that's a problem, let me know if it is.

riverrun commented 6 years ago

Yes, this is great. I just looked at the documentation (RFC 4226) , and it seems that they just recommend a minimum secret key length, so this should be fine.

zwippie commented 6 years ago

Cool! Did I need to bump the version number so a hex update would be easier?

riverrun commented 6 years ago

No. I'll do that today.