search

riverrun / phauxth

Not actively maintained - Authentication library for Phoenix, and other Plug-based, web applications
409 stars 20 forks source link

Change the way to get the current app's endpoint #30

Closed guidotripaldi closed 7 years ago

guidotripaldi commented 7 years ago

Instead to look for the configuration, the function now get the current app name and build from it the actual namespaced endpoint

riverrun commented 7 years ago

I am not sure about this solution. It seems like there is a bit of guesswork involved when working out the endpoint name.

I am going to think about it a bit more, and then look at this problem again tomorrow :)

I think I will probably change it so that the endpoint and token_salt will be passed in the opts (perhaps overriding a value defined in the config).

guidotripaldi commented 7 years ago

I agree. In addition this solution is not general, solves only the endpoint problem, it is not suitable for extracting the salt or other parameters.