search

riverrun / phauxth

Not actively maintained - Authentication library for Phoenix, and other Plug-based, web applications
409 stars 21 forks source link

Router.Helpers now needs to be explicitly aliased as Routes #65

Closed x-ji closed 6 years ago

x-ji commented 6 years ago

See https://github.com/phoenixframework/phoenix/commit/928cc6a3713bd64b949a0b102b849a93f1ce344d and https://github.com/phoenixframework/phoenix/issues/2530

When I tried mix phauxth.new, code such as user_path are generated in views, while it should really be Routes.user_path now, after this change in Phoenix.

I'm not sure if this is already addressed in version 2.0 of phauxth. A quick search doesn't seem to find any related issue, so I opened this.

riverrun commented 6 years ago

Thanks for opening the issue. I'll look into it soon.

riverrun commented 6 years ago

Do you know what version this was added?

x-ji commented 6 years ago

The changes are still in the master branch and I think in 1.4.0-dev, therefore they are not part of the current 1.3.x versions yet. Guess they'll go into effect when 1.4.0 is officially released. I just noticed them since I created a new project with 1.4.0-dev to test the built-in Webpack integration.

x-ji commented 6 years ago

Also see https://github.com/phoenixframework/phoenix/issues/2955

riverrun commented 6 years ago

Thanks. I noticed that they are not in the default installer, so I'm now looking at what the dev installer is producing and updating accordingly.

riverrun commented 6 years ago

I have just made some updates to the example app - using the assets folder generated from the dev installer, but I haven't added the Routes alias yet. I want to look into it further and then add it.

riverrun commented 6 years ago

I want to wait until Phoenix 1.4 comes out before adding the Routes alias - hopefully, that will be quite soon.

riverrun commented 6 years ago

Version 2.0.0 has these changes in the example app - once Phoenix 1.4 and Phauxth 2.0.0 are released, I will update the installer.