search

riverrun / phauxth

Not actively maintained - Authentication library for Phoenix, and other Plug-based, web applications
409 stars 20 forks source link

Resend confirmation email #66

Closed x-ji closed 5 years ago

x-ji commented 6 years ago

There doesn't seem to be a built-in solution for resending confirmation emails? Sometimes the email might be lost or end up in spam etc.

x-ji commented 6 years ago

Maybe this is already being dealt with in v2?

x-ji commented 6 years ago

The user can request password resets but even a successful password reset doesn't seem to confirm the account.

riverrun commented 6 years ago

No, there isn't a built-in solution, but I think that it is something that is outside the scope of this library. Your second comment about password reset not checking the confirmation is interesting, and I'll look into that soon.

x-ji commented 6 years ago

I mean it's pretty common for websites to provide a "resend confirmation email" link at the log in page, in addition to the "reset password" link, which this library already provides, so I don't think it is that out of scope. It can happen that the email service provider just wasn't able to send the email successfully for some reason. I was able to code it up relatively quickly, extending the confirm controller in a similar fashion to the password_reset controller, though it'd be nice if it's already generated in the templates IMO. I can also submit a PR if appropriate.

riverrun commented 5 years ago

Could you open an issue at https://github.com/riverrun/phauxth-example ? We can add this feature to the example.