search

riverrun / phauxth

Not actively maintained - Authentication library for Phoenix, and other Plug-based, web applications
409 stars 21 forks source link

Replace user_context arg with config #69

Closed todotentei closed 6 years ago

todotentei commented 6 years ago

As we able to use user_context config. So, I want to remove user_context argument from Login.Base and Confirm.Base, and move the user_context into opts with the default given by Config.user_context().

riverrun commented 6 years ago

Thanks again for your input. In this case, I am not going to accept this PR at the moment.

The main problem is that this will be a breaking change, which I don't want to introduce at the moment. However, I might add these changes that you are suggesting to version 2.0, which will be coming soon.

I have opened an issue for it here.

todotentei commented 6 years ago

I was thinking the same. May be we can add default user_context argument instead.