riverrun / phauxth

Not actively maintained - Authentication library for Phoenix, and other Plug-based, web applications
409 stars 21 forks source link

Remove some of the keyword arguments in the confirm modules #83

Closed riverrun closed 6 years ago

riverrun commented 6 years ago

In the confirm modules, keyword arguments can be used to overwrite the default config values.

This was first introduced to help support umbrella apps (due to the way the config files are handled), but I think this is probably no longer needed. The config for the user_context and endpoint can be set in the Endpoint module, and it is only in rare cases that a developer would want to overwrite those values. Even if a developer does want to overwrite them, he / she can still do so by use-ing the base module.

What do people think about removing these keyword argument options (and relying on the config values)?

riverrun commented 6 years ago

These changes have been added to the readd_login branch.

riverrun commented 6 years ago

These changes are present in the 2.0.0-beta