search

riverscuomo / spotkin_flutter

A front end for Spotkin server
https://spotkin.web.app
8 stars 4 forks source link

Banned genres still in playlist #58

Closed KCreek1 closed 3 months ago

KCreek1 commented 3 months ago

Despite adding genres to banned list, tracks from that genre are still being added to the playlist.

I double checked my list and updated manually and still were added.

image

image

image

Iimage

urbainn commented 3 months ago

image

the banned genres are correctly sent to the backend server, so this is most likely an issue with https://github.com/riverscuomo/spotkin . I'll try to see if I find anything there.

riverscuomo commented 3 months ago

I seem to remember there was some very specific logic there. Like where the genre falls in the list of artist genres. And even whether the genre matches exactly or whether it is a substring of one of the artists genres.

On Sat, Aug 10, 2024, 1:45 PM Urbain @.***> wrote:

image.png (view on web) https://github.com/user-attachments/assets/89de923c-258c-4ef9-a15a-56a7c68d13b2

the banned genres are correctly sent to the backend server, so this is most likely an issue with https://github.com/riverscuomo/spotkin . I'll try to see if I find anything there.

— Reply to this email directly, view it on GitHub https://github.com/riverscuomo/spotkin_flutter/issues/58#issuecomment-2282273534, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFZ32G2BHXJFN3WXFQICMSLZQZ3X5AVCNFSM6AAAAABMJ327T2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSGI3TGNJTGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

KCreek1 commented 3 months ago

I know for the new-albums script it has this to say about banned genres in the read me: that it would reject an artist if their first genre was found on the reject list.

But I didn't know if that is the same code used for spotkin.

I did have others on my playlist that had banned genres among the list of genres. So I figured they fell into the group where maybe it wasn't their first genre. I just included the examples above because they only showed one genre and that one was on the reject list.

urbainn commented 3 months ago

issue should be solved with this PR: https://github.com/riverscuomo/spotkin/pull/30 .