Rally dice roll results not truncated when auto-ordering

riverwanderer / ccnapoleonics

Commands & Colors: Napoleonics on vassalengine.org

https://boardgamegeek.com/boardgame/62222/commands-and-colors-napoleonics

GNU Lesser General Public License v2.1

0 stars 0 forks source link

Rally dice roll results not truncated when auto-ordering #284

Closed riverwanderer closed 1 month ago

riverwanderer commented 1 month ago

Module V5.1.0beta1 Vassal V3.7.14

Rally (and possibly Elan) no longer truncates unneeded dice results from the order count. Rally also reports multiple Rallies above the applied number when auto-rallying.

Working correctly in 5.0.0beta9.

Also, failing to auto-apply across multiple units:

284 - Rally auto-orders bug.zip

riverwanderer commented 1 month ago

Possible cause: #182.

riverwanderer commented 1 month ago

Analysis: gOrdersINF etc was used in place of gOrderINF etc, so conditions were not met for Rally to action correctly. Fix, renamed this property group to gOrdersXXX across the module (affecting Elan also), for consistency in future.

Also, gOrders update was referencing gOrdersXXX rather than gDiceXXX, unlike Elan.

Fix in a818, tested OK in different combinations.