riverwanderer / ccnapoleonics

Commands & Colors: Napoleonics on vassalengine.org
https://boardgamegeek.com/boardgame/62222/commands-and-colors-napoleonics
GNU Lesser General Public License v2.1
0 stars 0 forks source link

Take Command & Force March widgets allowed to persist preventing Play command in that hand #304

Closed riverwanderer closed 1 month ago

riverwanderer commented 1 month ago

Module V5.1.0beta7 Vassal V3.7.14

Card play disabled after a Drag to Play action. After a Take Command Any Section was dragged to the map to play, further Command card Menu (or Click) Play commands were disabled. Also Tactician cards probably.

Cause is that the Take Command (and Force March) cards set noPlay to disable play whilst their in-hand widget is displayed. Drag to play appears to mis-set this control, whereafter it cannot be cleared by the module.

OT24-3-1 ST v MB session 1.zip

riverwanderer commented 1 month ago

Prototype which confirms the problem (unzip, import and attach in CCCount p/type, refresh the game file, and then execute the patch via the Command card count).

noPlay.xml.zip

riverwanderer commented 1 month ago

Testing with a836 indicates that this issue has been fixed since beta7 but ability to Take Command & Force March to be played to the board should be considered.

riverwanderer commented 1 month ago

More info from Beta7; it is possible for the card play widgets to persist (this also may prevent the Play command): image

riverwanderer commented 1 month ago

The issues experienced are caused when click-to-play is used for Force March or Take Command, displayed an order-assist widget but another card is played, leaving the order-assist widget in place. By masking the entire hand and customising mouse-over hints the situation is avoided. Also, Take Command widgets were not checked for and removed at turn end, extending the issue to the rest of the game.

These cards still do not operate in Widget mode if Drag-to-Play is used.

Fixes in a840.