rivetTDA / rivet

RIVET is a tool for Topological Data Analysis, in particular two-parameter persistent homology.
GNU General Public License v3.0
73 stars 24 forks source link

reduce/eliminate use of boost::multi_array #113

Open mlesnick opened 6 years ago

mlesnick commented 6 years ago

These objects have unexpected assignment/copy properties (see presentation.h). As such, they are a bit of a pain. Currently, their weird behavior is inherited by Presentation class. The use of the boost::multi_array seems unnecessary; as far as I can tell, C++ STL vectors-of-vectors would work just as well.

Note that getting rid of the boost::multi_array's (which mostly appear in the code via the unsigned_matrix typedef) involves tinkering with the serialization code.