search

rivetTDA / rivet

RIVET is a tool for Topological Data Analysis, in particular two-parameter persistent homology.
GNU General Public License v3.0
73 stars 24 forks source link

module invariants file does not store homology dimension #117

Open delooper opened 6 years ago

delooper commented 6 years ago

If you save an output file from rivet_console, then load it in the RIVET GUI, it presents the computation as if it is a 0-dimensional homology computation, regardless of the dimension computed in rivet_console. i.e. the line at the bottom that describes the dimension always says "0".

I imagine either the dimension is not stored in rivet_console's output, or perhaps the GUI does not read it properly. This is more of an expositional problem, rather than a bug, but it can lead to confusion.

mlesnick commented 6 years ago

To add to this, in our pull request, some RIVET files (namely those constructed from 'firep' input) may not have a homology dimension at all, and homology dimension should be "N/A."

In fact, for firep input files the bottom of the main window also shows homology dimension 0 when it should show N/A, though the file input dialogue does already show N/A.

mlesnick commented 6 years ago

@xoltar, would the RIVET serialization need to be changed at all to address these issues?