search

rivetTDA / rivet

RIVET is a tool for Topological Data Analysis, in particular two-parameter persistent homology.
GNU General Public License v3.0
73 stars 24 forks source link

Issue with negative values in "Right" box for window adjustment #140

Closed mlesnick closed 5 years ago

mlesnick commented 5 years ago

For the example circle_300pts... included with RIVET (in the point cloud data folder), the window adjustment box "Right" behaves incorrectly. The density parameter is treated a descending-coordinate parameter in this example, and the trouble may be related to this. I'm not sure about the other boxes; I haven't seen any other problems there yet.

The issues I see are: 1)When I adjust the "Right" value, the behavior is weird. If I make the value negative (the default upon opening the file is 1), it then cannot be adjusted to a positive value.

2)If I make the value of "Right" negative, then the "Restore default window" restores the value to -1 (in the text box) not 1. But as far as I can tell, it does restore the window properly, so I guess the issue is just with the text box.

SimonSegert commented 5 years ago

Addressed, see commit 95e2435

mlesnick commented 5 years ago

Simon's fix seems to solve the problem.