search

rivetTDA / rivet

RIVET is a tool for Topological Data Analysis, in particular two-parameter persistent homology.
GNU General Public License v3.0
73 stars 24 forks source link

Simple bifiltration crash #143

Closed xoltar closed 5 years ago

xoltar commented 5 years ago

The following bifiltration (from the pyrivet test suite) crashes with SIGSEGV:

bifiltration x_label y_label 1 2 4 ; -1 -2
2 4 5 ; -1 -2
0 1 3 ; -1 -2
1 3 4 ; -1 -2
0 2 3 ; -1 -2
2 5 3 ; -1 -2
0 1 2 ; 3 -2
3 4 5 ; -1 2

mlesnick commented 5 years ago

I believe that the issue is with the input file. A while ago, the bifiltration input format was changed. To compute homology in dimension j, one must explicitly specify the simplices in dimension j-1,j,and j+1. RIVET no longer infers the faces from the top dimensional simplices.

xoltar commented 5 years ago

Ah, that explains it, thanks! I'll update the test suite then.