search

rivetTDA / rivet

RIVET is a tool for Topological Data Analysis, in particular two-parameter persistent homology.
GNU General Public License v3.0
74 stars 24 forks source link

Minor Issue with "view >> Betti_Number_Window" in rivet_GUI #154

Closed mlesnick closed 4 years ago

mlesnick commented 4 years ago

"view >> Betti_Number_Window," implemented by Simon in 2018, chooses the bounding recantangle of the line selection window to be the smallest one containing the support of the Betti numbers. (The default bounding rectangle is the smallest one containing the bigrades of all generators of the firep, which is usually strictly larger.) As shown in the top screenshot below, this functionality draws the vertical grey "guide lines" incorrectly (Mac OS X). For comparison, the bottom screenshot shows the usual, correct way the guide lines are drawn.

Simon and I never noticed this before; it is possible that we just missed it, or tit may be hat some update to qt changed the behavior. In any case, it should be a relatively straightforward fix.

Betti_Number_Window_Bug

proper_view_for_comparison

mlesnick commented 4 years ago

After more exploration, I discovered that this is not a bug, but a feature which I misunderstood; independent of the bounds chosen, the light grey lines outline the smallest box containing the bigrades of all generators for the firep.