rivetTDA / rivet

RIVET is a tool for Topological Data Analysis, in particular two-parameter persistent homology.
GNU General Public License v3.0
74 stars 24 forks source link

use a color-blind friendly palatte #157

Closed mikepierce closed 2 years ago

mikepierce commented 4 years ago

Changed the colors in the interface to be colorblind accessible using Bang Wong's 7-color palette. Also upped the opacity a bit since the new palette is less vibrant.

screenshot

mlwright84 commented 4 years ago

Thanks, Mike, for implementing this color scheme. Mike Lesnick and I suggest creating a compile-time flag that controls whether the default colors are the current color scheme or the accessible color scheme. We would also like to add a button to the Configure dialog box that selects the accessible colors. If you are interested in adding these enhancements, feel free to do so, otherwise we will add it to our todo list. Thanks!

mikepierce commented 4 years ago

Yeah, it's on my radar to do this. I'm not sure when I'll find time get around to digging in and figuring out how to do it though, so you might want to throw this on the todo list and point to this pull request anyways. :) But it is summer … I should find the time.

mlesnick commented 4 years ago

Hi Mike, thanks. if you don't know qt already, I'd imagine that adding the compiler flags is considerably easier than adding the button in qt. I think we could merge a pull request with the compiler flags first and leave the button for afterwards.

I don't have any experience with this, but I just did some quick "research":

Implementing the compile flags would involve three changes, each of which looks to be easy:

1.Add preprocessor directives #ifdef...#else...#endif to interface/config_parameters.cpp

You can look at the Ripser code for examples: https://github.com/Ripser/ripser/blob/master/ripser.cpp

2.Update CMakeLists.txt to allow the user to invoke the compile flag as an argument to cmake: http://zumguy.com/using-cmake-to-set-preprocessor-directives/

3.Update the documentation (the file is "installing.rst") to mention the accessible colors option.

On Sun, Jun 21, 2020 at 4:49 PM Mike Pierce notifications@github.com wrote:

Yeah, it's on my radar to do this. I'm not sure when I'll find time get around to digging in and figuring out how to do it though, so you might want to throw this on the todo list and point to this pull request anyways. :) But it is summer … I should find the time.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rivetTDA/rivet/pull/157#issuecomment-647179871, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC72KBB4Z53ESCI36WTCYD3RXZW4TANCNFSM4NWS6JZQ .