search

rivetTDA / rivet

RIVET is a tool for Topological Data Analysis, in particular two-parameter persistent homology.
GNU General Public License v3.0
73 stars 24 forks source link

Incorrect Behavior When Closing RIVET #41

Closed mlesnick closed 7 years ago

mlesnick commented 8 years ago

Originally reported by: M L (GitHub: mlesnick)

-When the file selection dialogue box is closed, a blank RIVET window appears.

-When a RIVET computation in progress is stopped before Betti numbers are computed, a blank window remains open.

I suggest that the RIVET window be opened only after the Betti numbers are computed.

mlesnick commented 8 years ago

Original comment by Matthew Wright (GitHub: mlwright84):

This issue resolved in commits 0b0d107 and f6bb9c3 on Jan. 28, 2016.

Closing the data selection dialog box without clicking "Compute" now closes RIVET. Also, stopping the computation before the augmented arrangement is computed now closes RIVET.

Because the RIVET main window is a QMainWindow, Qt automatically calls its show() event when RIVET starts. Thus, I could not figure out how to prevent it from appearing on the screen if the user closes RIVET before the computation finishes. For now, the best I can do is make the main window close automatically if the user closes RIVET through one of the dialog boxes.

Somewhat related to this issue -- if the user saves the augmented arrangment to a file, RIVET no longer prompts the user that "unsaved data will be lost" when closing RIVET, because there is no unsaved data in this case.