rivetTDA / rivet

RIVET is a tool for Topological Data Analysis, in particular two-parameter persistent homology.
GNU General Public License v3.0
74 stars 24 forks source link

Improper Behavior in Upper Strips for Points with Multiplicity #42

Closed mlesnick closed 7 years ago

mlesnick commented 8 years ago

Originally reported by: M L (GitHub: mlesnick)


For points in the upper strips of the persistence diagram, the multiplicity of an interval is not always properly represented by the size of the dot. Instead, since the dots are translucent, the multiplicity is represented by the shading of the dot. (This is not what we want).

We need to merge dots in the upper strip that correspond to the same coordinate. For a generic query line, all such dots correspond to template points that have the same first coordinate, so this shouldn't be very hard. Mike

mlesnick commented 8 years ago

Original comment by Matthew Wright (GitHub: mlwright84):


This issue is now resolved.

One caveat: Resizing the RIVET window now removes any highlighting from bars and dots. This isn't really a problem, and we can preserve highlighting on window resize in the future. However, doing so will be a bit tricky because resizing the window can cause dots to move in or out of the "less than infinity" strip in the persistence diagram, so a highlighted dot in the strip might split into two dots.

mlesnick commented 8 years ago

Original comment by M L (GitHub: mlesnick):


I just changed the priority of this to major. Playing with the neuro eccentricity data, I see it has the potential to cause confusion.

If I didn't understand in advance that this is an issue, I might be very confused by the output I am seeing:

Screen Shot 2016-01-22 at 11.13.30 AM.png

For this reason, I think it might be a good idea to fix this before release.