search

rivetTDA / rivet

RIVET is a tool for Topological Data Analysis, in particular two-parameter persistent homology.
GNU General Public License v3.0
73 stars 24 forks source link

Consistency in BRips and x- and y-coordinate convention #54

Closed mlesnick closed 7 years ago

mlesnick commented 8 years ago

Originally reported by: M L (GitHub: mlesnick)

In Roy's new BRips code, the scale parameter is the x-coordinate, but in Matthew's 2-D Rips code (as well as Roy's new version of it) the scale parameter is the y-coordinate. For consistency with the RIVET paper and with Matthew's code, I suggest that in Roy's BRips code, the scale parameter be the y-coordinate.

mlesnick commented 8 years ago

Original comment by rhzhao (GitHub: rhzhao):

I changed my code appropriately.