search

rivetTDA / rivet

RIVET is a tool for Topological Data Analysis, in particular two-parameter persistent homology.
GNU General Public License v3.0
73 stars 24 forks source link

Slice line can be put in an illegal place using up/down buttons #56

Open mlesnick opened 8 years ago

mlesnick commented 8 years ago

Originally reported by: M L (GitHub: mlesnick)

I just discovered this issue, because I never adjust the line with these buttons.

Should we just remove the up/down buttons altogether?

mlesnick commented 7 years ago

Original comment by Matthew Wright (GitHub: mlwright84):

We will return to this later.

mlesnick commented 7 years ago

Original comment by Matthew Wright (GitHub: mlwright84):

We will return to this later.

mlesnick commented 8 years ago

Original comment by Matthew Wright (GitHub: mlwright84):

I now recall that it is possible to put the line in an illegal place with the angle and offset buttons.

I think that the angle and offset selectors are important because they provide the user with numerical parameters for the line, and allow the user to specify the line by such parameters. For example, this would be important if the user wants to remember a very specific line that they would like to return to later.

It shouldn't be hard to add some if statements that ensure that these buttons do not cause the line to move outside of the box.