rivetTDA / rivet

RIVET is a tool for Topological Data Analysis, in particular two-parameter persistent homology.
GNU General Public License v3.0
73 stars 24 forks source link

RIVET GUI Version Doesn't Start (Alex's Yu's OS X) #57

Closed mlesnick closed 7 years ago

mlesnick commented 8 years ago

Originally reported by: M L (GitHub: mlesnick)


So far we have only seen this error on Alex Yu's laptop.

RIVET file dialog box doesn't open when RIVET is started.

With Matthew's help, Alex was able to work around this problem by making two changes to Alex's code:

First, in main.cpp, change

QScopedPointer app(createApplication(argc, argv));

to the line (currently commented out below)

/QScopedPointer app(new QApplication(argc, argv));

Second, in visualizationwindo.cpp, change

ds_dialog.show(); [line 374]

to

ds_dialog.exec();

FWIW, these changes also seem compatible with the version of OSX on my laptop.

Should these changes be incorporated into the repository?

mlesnick commented 7 years ago

Original comment by Bryn Keller (GitHub: xoltar):


Fixed in 296148e

mlesnick commented 7 years ago

Original comment by Matthew Wright (GitHub: mlwright84):


Marked as open