rivetTDA / rivet

RIVET is a tool for Topological Data Analysis, in particular two-parameter persistent homology.
GNU General Public License v3.0
73 stars 24 forks source link

Bug with the dashed lines for infinite bars #59

Closed mlesnick closed 7 years ago

mlesnick commented 8 years ago

Originally reported by: M L (GitHub: mlesnick)


When clicking on the line for a pair of bars with the same start time and infinite end time, one of the lines is dashed, and one is not. There should be no dashed line here

Screen Shot 2016-07-19 at 12.36.58 AM.png

mlesnick commented 7 years ago

Original comment by Matthew Wright (GitHub: mlwright84):


Resolved in commit 0a6a51c.

mlesnick commented 7 years ago

Original comment by Matthew Wright (GitHub: mlwright84):


I have identified the cause of this issue: One of the infinite bars is infinite when its endpoints are pushed onto any line. The other infinite bar is only infinite because the selected line is horizontal and its endpoint is above the horizontal line; this bar is finite if the slope of the line is positive.

I think that the solution is to modify VisualizationWindow::rescale_barcode_template() to combine bars in this situation (so that they become one bar with multiplicity), but this is a bit tricky. I'm working on the fix.

mlesnick commented 7 years ago

Original comment by M L (GitHub: mlesnick):


I think this is the one. It is actually not computed correctly, as the codensity estimate was miscomputed. The file I gave below was a corrected version.

But nevertheless it should help in finding the bug, I think.

mlesnick commented 7 years ago

Original comment by Matthew Wright (GitHub: mlwright84):


Mike, I don't think the data file is correct here. Here is what I see when I load the data file into an old version of RIVET:

Screenshot from 2016-12-20 17-39-37.png

It doesn't match your screenshot.

mlesnick commented 7 years ago

Original comment by M L (GitHub: mlesnick):


In spite of the name, I think this is the right file.

mlesnick commented 7 years ago

Original comment by M L (GitHub: mlesnick):


Precomputed File in old format.