rivetTDA / rivet

RIVET is a tool for Topological Data Analysis, in particular two-parameter persistent homology.
GNU General Public License v3.0
73 stars 24 forks source link

RIVET Crashes with Filtrations with Many Bigrades #68

Closed mlesnick closed 6 years ago

mlesnick commented 7 years ago

This is an issue with how RIVET is handling exact vs. floating point computation in computing the line arrangement.

Our experience is that working with coarsened filtrations (say 20x20 or coarser) circumvents this bug.

[There was a long discussion of this bug in the earlier issue tracker on bitbucket. Properly transferring all of this over to here is difficult for several reasons, so I'll simply note that Matthew has identified the cause of the bug and is in the progress of squashing it.]

Matthew has determined that this is due to a numerical error in the implementation of the Bentley-Ottoman algorithm. The issue is with how RIVET implements hybrid floating-point/exact arithmetic.

mlesnick commented 7 years ago

Original comment by M L (GitHub: mlesnick):


This may be related to issue #76. See that issue for other test data (the senate/house data).

mlwright84 commented 6 years ago

Resolved in Pull Request #107.