Possible to save diagram while arrangement still building, can segfault

rivetTDA / rivet

RIVET is a tool for Topological Data Analysis, in particular two-parameter persistent homology.

GNU General Public License v3.0

73 stars 24 forks source link

Possible to save diagram while arrangement still building, can segfault #71

Closed mlesnick closed 7 years ago

mlesnick commented 7 years ago

Originally reported by: Bryn Keller (GitHub: xoltar)

With the viewer, while processing a file, it is possible to save before completion. In some cases this can cause a segfault. In others it probably just creates an invalid file, haven't tried that. The save function should be disabled until the processing is complete.

mlesnick commented 7 years ago

Original comment by Bryn Keller (GitHub: xoltar):

Fixed in e05e1e9

mlesnick commented 7 years ago

Original comment by Bryn Keller (GitHub: xoltar):

I'll take a look.

mlesnick commented 7 years ago

Original comment by Matthew Wright (GitHub: mlwright84):

Bryn, thanks for pointing this out. I think this should be easy to fix. Would you like to do so? I would also be glad to fix this -- just let me know.