search

rivetTDA / rivet

RIVET is a tool for Topological Data Analysis, in particular two-parameter persistent homology.
GNU General Public License v3.0
73 stars 24 forks source link

Vineyard Computation Abort #81

Closed mlesnick closed 6 years ago

mlesnick commented 7 years ago

Originally reported by: M L (GitHub: mlesnick)

InJune 2016, Matthew and I agreed that RIVET should have an option to give up on a vineyard update if it is taking too much time: If RIVET is taking more than, say, 10x the time of an average computation of a decomposition from scratch, then RIVET should give up and just do the computation from scratch.

We have tried to design the thresholding algorithms to avoid threshold computations where vineyards end up being way too slow, but our algorithms for this are just heuristics, and frankly, not especially well vetted heuristics. It is still quite possible that some case will arise where these heuristics do badly.

This is low priority now, but depending on how further RIVET tests go, it might become important later.

mlesnick commented 6 years ago

It is probably better to replace the vineyard functionality altogether with something simpler that will render this issue moot. In any case, with the new changes to RIVET, the vineyard computations are no longer the bottleneck, at least for the examples we are looking at now.