carpii commented 1 year ago

Addresses the limitation that there's no way to iterate over pages currently, which is useful for highly dynamic apps (and providing Alt-Tab functionality)

GiGurra commented 7 months ago

This would be great to have. Is there any way to upvote/get this some attention?

Or is the project semi dead or considered feature complete? :(

rivo commented 7 months ago

See https://github.com/rivo/tview/blob/master/CONTRIBUTING.md#pull-requests

But looking at this now, this PR has multiple issues:

Using snake case for variable names
Using the slices package which requires Go 1.21. We're at Go 1.18 in tview and last time I upgraded the minimum version (and I did so long after Go 1.18 was released), I was showered with tons of complaints because it broke a lot of builds. The slices package has been introduced officially about half a year ago so I would like to wait a bit before bumping the Go version again.
Minor but still: "Start all sentences upper-case, as is common in English, and end them with a period." (While you're add it, please wrap lines at a maximum of 80 characters.)

carpii commented 7 months ago

Pull request replaced with https://github.com/rivo/tview/pull/971

rivo commented 7 months ago

970 looks good but you closed it...

carpii commented 7 months ago

Sorry, I made a bit of a mess of the push

Replaced with #971

rivo / tview

added Page.GetPageNames(visible_only bool) API #874

970 looks good but you closed it...