search

rivo / uniseg

Unicode Text Segmentation, Word Wrapping, and String Width Calculation in Go
MIT License
570 stars 60 forks source link

golang v1.19 support #25

Closed bilalcaliskan closed 1 year ago

bilalcaliskan commented 1 year ago

Currently we are having problem while using this library with Golang v1.19 projects.

note: module requires Go 1.18

Golang 1.19 is now latest stable version. Are you planning to support v1.19 soon?

rivo commented 1 year ago

v1.18 is the minimum version. uniseg works fine with v1.19. I wonder what actual problems you are having?

bilalcaliskan commented 1 year ago

the whole error is like below

# github.com/rivo/uniseg
Error: vendor/github.com/rivo/uniseg/properties.go:130:6: missing function body
Error: vendor/github.com/rivo/uniseg/properties.go:130:20: syntax error: unexpected [, expecting (
note: module requires Go 1.18

but the funny thing, i am not getting the same error on my local machine, i get that error only Github Actions which is my CI environment

rivo commented 1 year ago

This sounds very much like GitHub Actions is running a Go version older than 1.18. It doesn't recognize generics, which were introduced in 1.18.

bilalcaliskan commented 1 year ago

thats exactly what you ve said! thanks for your rapid help, i am closing this issue since it is not related with uniseg anymore.